[webkit-reviews] review granted: [Bug 63361] add flexbox and inline-flexbox as possible CSS display values : [Attachment 98554] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 63361: add flexbox and inline-flexbox as possible CSS display values
https://bugs.webkit.org/show_bug.cgi?id=63361

Attachment 98554: Patch
https://bugs.webkit.org/attachment.cgi?id=98554&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98554&action=review

> LayoutTests/css3/flexbox/script-tests/display-property.js:6
> +function testFlex(displayValue)
> +{
> +    return div.style[styleAttribute];
> +}

Unused.

> LayoutTests/css3/flexbox/script-tests/display-property.js:11
> +div.style.display = '-webkit-flexbox';
> +shouldBeEqualToString('div.style.display', '-webkit-flexbox');

You could move this into testFlex.

> Source/WebCore/css/CSSParser.cpp:972
> +	   // table-column-group | table-column | table-cell | table-caption |
-webkit-box | -webkit-inline-box | none | inherit

Should this include -webkit-flexbox and -webkit-inline-flexbox?

Not really sure this comment is useful though.