[webkit-reviews] review denied: [Bug 63112] nrwt: make sharding tests needing locks less hard-coded : [Attachment 98308] fix rebase

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 63112: nrwt: make sharding tests needing locks less hard-coded
https://bugs.webkit.org/show_bug.cgi?id=63112

Attachment 98308: fix rebase
https://bugs.webkit.org/attachment.cgi?id=98308&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98308&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:637
> +	   self._pending_locked_shards = locked_shards

should this be self._remaining_locked_shards? If so, it would be nice to also
add a test that breaks given that we never seem to add anything to
_remaining_locked_shards.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:1372
> +	       return

don't need the return statement.