[webkit-reviews] review denied: [Bug 62375] Forward focus events to windowless plugins on the windows port. : [Attachment 96583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 08:33:11 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 62375: Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375

Attachment 96583: Patch
https://bugs.webkit.org/attachment.cgi?id=96583&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96583&action=review

Thanks for working on this! You should fix this for WebKit2 at the same time.
You can find the relevant code in Source/WebKit2/WebProcess/Plugins, I believe.


> Source/WebCore/ChangeLog:11
> +	   (WebCore::PluginView::handleKeyboardEvent):	Don't send random
keyboard
> +	   events to the plugin (npEvent.event was being used uninitialized).

This has nothing to do with focus events, so should be split out into its own
bug and patch.


More information about the webkit-reviews mailing list