[webkit-reviews] review denied: [Bug 62914] Incorrectly placed SVG gradients can cause crashes when referenced : [Attachment 97896] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 08:43:44 PDT 2011


Dirk Schulze <krit at webkit.org> has denied Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 62914: Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Attachment 97896: Patch
https://bugs.webkit.org/attachment.cgi?id=97896&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Given the fact that firefox does not handle the case as well, we can land the
fix. But please update the ChangeLog that we follow Firefox on handling such
cases.

Can you please update your test to the style of
https://bugs.webkit.org/show_bug.cgi?id=62914#c2 ? There is no need to add
unnecessary elements and information. Make test cases as simple as possible.
But it should still be a dumpAsText test of course.


r- because of the test.


More information about the webkit-reviews mailing list