[webkit-reviews] review denied: [Bug 62372] [CSSRegions] Add build slave : [Attachment 96585] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 62372: [CSSRegions] Add build slave
https://bugs.webkit.org/show_bug.cgi?id=62372

Attachment 96585: Patch
https://bugs.webkit.org/attachment.cgi?id=96585&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96585&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242
> +		       { "name": "Adobe SnowLeopard Intel Release (Build)",
"type": "Build", "builddir": "adobe-snowleopard-intel-release",

We don't currently have any builders with company names in them. The important
thing is the flavor of WebKit that runs on the builder and what kinds of
operations it performs, not who maintains the slaves used by that builder. (In
fact, you could have multiple different companies that maintain slaves that are
used by a single builder.) I'd recommend giving this builder a name that that
indicates its purpose.