[webkit-reviews] review denied: [Bug 62263] [Chromium] Remove stubs for WebWidget::willStartLiveResize and WebWidget::willEndLiveResize : [Attachment 96379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 16:39:27 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 62263: [Chromium] Remove stubs for WebWidget::willStartLiveResize and
WebWidget::willEndLiveResize
https://bugs.webkit.org/show_bug.cgi?id=62263

Attachment 96379: Patch
https://bugs.webkit.org/attachment.cgi?id=96379&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
I think a better fix would be to make all of the methods have default
implementations
since there is an implementation of WebWidget in the Chromium repository.  If
you don't
do that then we will continually have to repeat this exercise.	It would be
better if
the code guided people to add default implementations (which is what we do for
other
interfaces that Chromium implements -- e.g., WebFrameClient).


More information about the webkit-reviews mailing list