[webkit-reviews] review granted: [Bug 61908] [chromium] PageSerializer::generateMHTML() should return a WebData : [Attachment 95933] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 16:34:25 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 61908: [chromium] PageSerializer::generateMHTML() should return a WebData
https://bugs.webkit.org/show_bug.cgi?id=61908

Attachment 95933: Patch
https://bugs.webkit.org/attachment.cgi?id=95933&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95933&action=review

>>> Source/WebKit/chromium/public/WebData.h:90
>>> +	 WEBKIT_API size_t getSomeData(const char*& data, size_t position)
const;
>> 
>> why do you need this method when you already have direct access to the
entire buffer
>> via the "data" method?
> 
> From SharedBuffer.h about data():
> "Calling this function will force internal segmented buffers to be merged
into a flat buffer. Use getSomeData() whenever possible for better
performance."

OK, I see.  I think it would help then to extend the comment above "data()"
to explain why getSomeData() should be preferred (i.e., that it could require
flattening the internal buffer).


More information about the webkit-reviews mailing list