[webkit-reviews] review denied: [Bug 62067] [chromium] Give VoidCallbackClient a virtual destructor : [Attachment 95986] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 62067: [chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067

Attachment 95986: Patch
https://bugs.webkit.org/attachment.cgi?id=95986&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95986&action=review

> Source/WebKit/chromium/src/NotificationPresenterImpl.cpp:59
> +    virtual ~VoidCallbackClient() { }

this should be protected or private!!  notice how this class deletes itself.
no one else should be deleting this class.