[webkit-reviews] review denied: [Bug 64518] removes #if ENABLE(DRAG_SUPPORT) check : [Attachment 100788] removes last ENABLE(DRAG_SUPPORT) gtk check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 24 18:12:52 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 64518: removes #if ENABLE(DRAG_SUPPORT) check
https://bugs.webkit.org/show_bug.cgi?id=64518

Attachment 100788: removes last ENABLE(DRAG_SUPPORT) gtk check
https://bugs.webkit.org/attachment.cgi?id=100788&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100788&action=review


This seems fine. It's still used in other places throughout WebCore, but
otherwise, only Mac uses it in the platform layer. Please fix the ChangeLog,
then we can use the commit-queue to commit this.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You should remove this line.


More information about the webkit-reviews mailing list