[webkit-reviews] review requested: [Bug 64878] [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2) : [Attachment 101843] fix ANGLE compile flags

[bugzilla-daemon at webkit.org]

Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 64878: [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)
https://bugs.webkit.org/show_bug.cgi?id=64878

Attachment 101843: fix ANGLE compile flags
https://bugs.webkit.org/attachment.cgi?id=101843&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
(In reply to comment #6)
> 
> Sorry, I can't let an overarching disabling of warnings in...
> We have to figure out a way to diable these for ANGLE files only,
> or to live with those warnings being outputted when we build the ANGLE files.


I defined a new compiler in QMAKE_EXTRA_COMPILERS, which is just QMAKE_CXX but
with the extra warnings turned off and is used only for the ANGLE source files.


> All this should be under !CONTAINS(QT_CONFIG, opengles2)
>
> > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:32
> > +#if ENABLE(WEBGL) && !defined(QT_OPENGL_ES_2)
> 
> See previous comment. We can put this in the .pro file under
> contains(QT_CONFIG, opengles2)

Both are done.