[webkit-reviews] review granted: [Bug 65087] Fix CSSFontSelector::addFontFaceRule() : [Attachment 101837] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65087: Fix CSSFontSelector::addFontFaceRule()
https://bugs.webkit.org/show_bug.cgi?id=65087

Attachment 101837: Patch
https://bugs.webkit.org/attachment.cgi?id=101837&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101837&action=review


r=me on the idea of making the code work, but clearly we need regression tests
before we actually make a change.

And we need to consider what behavior you want as you and Mitz discussed above.


> Source/WebCore/ChangeLog:10
> +	   The varibable "familyName" is declared twice in this function.
> +	   The second decleration hides the first one and makes the whole
> +	   code in the the second useless.

You mean "defined", not "declared".

varibable -> variable
decleration -> declaration