[webkit-reviews] review denied: [Bug 63013] [EFL] Page Cache was not Enabled(Enable Page Cache) : [Attachment 101431] patch for efl port back/forward cache enable

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied DongJae KIM
<dongjae1.kim at samsung.com>'s request for review:
Bug 63013: [EFL] Page Cache was not Enabled(Enable Page Cache)
https://bugs.webkit.org/show_bug.cgi?id=63013

Attachment 101431: patch for efl port back/forward cache enable
https://bugs.webkit.org/attachment.cgi?id=101431&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101431&action=review


Needs one more interaction for clearance.

> Source/WebKit/efl/ewk/ewk_view.cpp:4595
> + * Restore cached page contents size.
> + * 
> + * This method must be called before WebCore::FrameView::layout().

How does the code ensure that? It is too error-prone, imo.

> Tools/ChangeLog:10
> +	   When view port changed, zoom level was set. ewk_view_zoom_set()
check zoom range
> +	   but zoom range value was old one.
> +	   So, I changed setting sequence.

typo: checkS*

Not sure if I understood this sentence.