[webkit-reviews] review granted: [Bug 64995] Web Inspector: [REGRESSION r89960-r91561] inconsistent state for Scripts panel, not paused but paused. : [Attachment 101731] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 64995: Web Inspector: [REGRESSION r89960-r91561] inconsistent state for
Scripts panel, not paused but paused.
https://bugs.webkit.org/show_bug.cgi?id=64995

Attachment 101731: Patch
https://bugs.webkit.org/attachment.cgi?id=101731&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101731&action=review


> LayoutTests/http/tests/inspector/debugger-test.js:118
> +	       lineNumber = "(line number)";

Consider living it undefined.

> LayoutTests/inspector/debugger/pause-in-internal-script.html:21
> +    InspectorTest.runDebuggerTestSuite([

You don't need runDebuggerTestSuite, just inline testSetBreakpoint body here.

> LayoutTests/inspector/debugger/pause-in-internal-script.html:47
> +<p>Tests that internal scripts unknown to front-end are processed correctly
when appear in debugger call frames.

Link to the bug?