[webkit-reviews] review granted: [Bug 64259] [EFL] Implement EditorClientEfl::respondToChangedContents : [Attachment 100303] changes according to Raphael's suggestions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 22 07:59:22 PDT 2011
Antonio Gomes <tonikitoo at webkit.org> has granted Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 64259: [EFL] Implement EditorClientEfl::respondToChangedContents
https://bugs.webkit.org/show_bug.cgi?id=64259
Attachment 100303: changes according to Raphael's suggestions
https://bugs.webkit.org/attachment.cgi?id=100303&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100303&action=review
> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:125
> + Evas_Object* frame = ewk_view_frame_focused_get(m_view) ?
ewk_view_frame_focused_get(m_view) : ewk_view_frame_main_get(m_view);
I would not call the getter twice here.
More information about the webkit-reviews
mailing list