[webkit-reviews] review denied: [Bug 65008] REGRESSION(r89535): Form reset doesn't redraw a file upload control : [Attachment 101711] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 65008: REGRESSION(r89535): Form reset doesn't redraw a file upload control
https://bugs.webkit.org/show_bug.cgi?id=65008

Attachment 101711: Patch
https://bugs.webkit.org/attachment.cgi?id=101711&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101711&action=review


The code change looks ok.

> LayoutTests/fast/forms/file-input-reset-expected.html:16
> +<div id="console">
> +<p>
> +This tests whether the label next to the file chooser button becomes "No
file chosen"
> +when we press the reset button.
> +To run this test manually, choose a file and then click the reset button.
> +If the label next to the file chooser button changes to "No file chosen",the
test passes.
> +</p>

<div id=console> is not needed.

> LayoutTests/fast/forms/file-input-reset.html:10
> +<div id="console">

ditto.

> LayoutTests/fast/forms/file-input-reset.html:24
> +    var reset = document.getElementById("reset");
> +    click(reset.offsetLeft + reset.offsetWidth / 2, reset.offsetTop +
reset.offsetHeight / 2);
> +    click(reset.offsetLeft + reset.offsetWidth + 10, reset.offsetTop +
reset.offsetHeight + 10); // Move a cursor out of the reset button.

Why don't you use getElementById('form').reset()?

> Source/WebCore/ChangeLog:8
> +	   This is a regression caused by r98535. This patch fixes the code

r98535 -> r89535.
Anyway, If you change the 1-list summary to "REGRESSION(r89535): Form reset
doesn't redraw a file upload control", this sentence is not needed.