[webkit-reviews] review requested: [Bug 55036] [Qt] FontCache::createFontPlatformData() is broken, a default font is returned even if the family does not match : [Attachment 101713] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 22 04:58:38 PDT 2011


Pierre Rossi <pierre.rossi at gmail.com> has asked  for review:
Bug 55036: [Qt] FontCache::createFontPlatformData() is broken, a default font
is returned even if the family does not match
https://bugs.webkit.org/show_bug.cgi?id=55036

Attachment 101713: patch v2
https://bugs.webkit.org/attachment.cgi?id=101713&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
This might require synchronizing for the the bots since the #ifdef will break
the build until Qt is bumped to have QFontDatabase::hasFamily().
And an obscene number of layout tests results are going to need to be updated
as a result, not sure how to do that properly.


More information about the webkit-reviews mailing list