[webkit-reviews] review denied: [Bug 65023] Web Inspector: the max depth of the Timeline events' stack trace should be customizable. : [Attachment 101712] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 65023: Web Inspector: the max depth of the Timeline events' stack trace
should be customizable.
https://bugs.webkit.org/show_bug.cgi?id=65023

Attachment 101712: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=101712&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101712&action=review


> Source/WebCore/inspector/Inspector.json:1397
> +		       { "name": "maxJSCallStackDepth", "optional": true,
"type": "integer" },

maxCallStackDepth

missing description field: Samples JavaScript stack traces up to
<code>maxCallStackDepth</code>, defaults to 5.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:126
> +	   start(&error, &m_maxJSCallStackDepth);

This value should be taken from the cookie.