[webkit-reviews] review granted: [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's : [Attachment 99987] Teach webkitpy's Checkout class to use commit-log-editor to create commit messages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 09:31:40 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 26755: webkit-patch's commit messages are less readable than
commit-log-editor's
https://bugs.webkit.org/show_bug.cgi?id=26755

Attachment 99987: Teach webkitpy's Checkout class to use commit-log-editor to
create commit messages
https://bugs.webkit.org/attachment.cgi?id=99987&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99987&action=review

r=me

> Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:124
> +	       return os.path.abspath(os.path.join(os.path.dirname(__file__),
'..', '..', '..', script))

There isn't a better way to get the path to the Tools directory (during a
test)?


More information about the webkit-reviews mailing list