[webkit-reviews] review denied: [Bug 63622] Web Inspector: Adding CSS properties results in messy style rules : [Attachment 99993] [PATCH] Removed parameter name

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 63622: Web Inspector: Adding CSS properties results in messy style rules
https://bugs.webkit.org/show_bug.cgi?id=63622

Attachment 99993: [PATCH] Removed parameter name
https://bugs.webkit.org/attachment.cgi?id=99993&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99993&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:56
> +static inline bool isWhitespace(UChar ch)

Let the compiler decide.

> Source/WebCore/inspector/InspectorStyleSheet.cpp:156
>
+InspectorStyleTextEditor::InspectorStyleTextEditor(Vector<InspectorStyleProper
ty>* disabledProperties, const std::pair<String, String>& format)

According to its size, it deserves its own file.

typedef the pair.

> Source/WebCore/inspector/InspectorStyleSheet.cpp:477
> +    ensureTextEditor(&allProperties, text);

I'd allocate editor on stack and use it once.