[webkit-reviews] review granted: [Bug 62447] dump-as-markup.js should support shadow tree : [Attachment 99952] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 09:37:14 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 62447: dump-as-markup.js should support shadow tree
https://bugs.webkit.org/show_bug.cgi?id=62447

Attachment 99952: Patch
https://bugs.webkit.org/attachment.cgi?id=99952&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99952&action=review

r=me provided you address the following points.

> LayoutTests/ChangeLog:8
> +	   - Added Markup.showShadows() to enable shadow-related dump.

Please update ChangeLog.

> LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:1
> +

You should explain what output you'd expect to see.

>
LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:1

> +

Ditto.


More information about the webkit-reviews mailing list