[webkit-reviews] review granted: [Bug 66156] Switch RenderBox to to new layout types : [Attachment 103984] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:30:55 PDT 2011


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 66156: Switch RenderBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66156

Attachment 103984: Patch
https://bugs.webkit.org/attachment.cgi?id=103984&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103984&action=review


> Source/WebCore/rendering/RenderBox.cpp:1151
> +    LayoutRect clipRect(location + LayoutSize(borderLeft(), borderTop()),

Isn't this borderRect().location?

> Source/WebCore/rendering/RenderBox.cpp:1864
> -	       logicalHeight = h.value();
> +	       logicalHeight = h.calcFloatValue(0);

Why?


More information about the webkit-reviews mailing list