[webkit-reviews] review granted: [Bug 66147] Switch FrameView to to new layout types : [Attachment 103988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:28:42 PDT 2011


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 66147: Switch FrameView to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66147

Attachment 103988: Patch
https://bugs.webkit.org/attachment.cgi?id=103988&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103988&action=review


Please ping me over IRC if I don't notice your patches wihtin a couple hours of
posting.  I'm not reading email that regularly at the moment as I'm focusing on
codding.

> Source/WebCore/page/FrameView.cpp:2217
> +	   return LayoutRect(LayoutPoint(0, 0), contentsSize());

The 0, 0 isn't needed.


More information about the webkit-reviews mailing list