[webkit-reviews] review granted: [Bug 66250] Switch RenderTextControl* to new layout types : [Attachment 103947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:31:59 PDT 2011


Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 66250: Switch RenderTextControl* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66250

Attachment 103947: Patch
https://bugs.webkit.org/attachment.cgi?id=103947&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103947&action=review


> Source/WebCore/rendering/LayoutTypes.h:97
> +inline LayoutUnit layoutMod(const LayoutUnit& numerator, const LayoutUnit&
denominator)
> +{
> +    return numerator % denominator;
> +}

Otherwise the compiler gets sad about mis-matched types?


More information about the webkit-reviews mailing list