[webkit-reviews] review denied: [Bug 59234] CrossThreadCopier should not have a default specialization for raw pointers : [Attachment 90931] Style issues fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 26 16:30:50 PDT 2011
Eric Seidel <eric at webkit.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 59234: CrossThreadCopier should not have a default specialization for raw
pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Attachment 90931: Style issues fixed
https://bugs.webkit.org/attachment.cgi?id=90931&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90931&action=review
> Source/WebCore/fileapi/FileReader.cpp:133
> + scriptExecutionContext()->postTask(
> + createCallbackTask(&delayedStart, AllowExtendedLifetime(this)));
webkit has no column limit.
> Source/WebCore/platform/CrossThreadCopier.h:142
> + template<typename T> struct AllowExtendedLifetimeWrapper {
> + public:
> + explicit AllowExtendedLifetimeWrapper(T* value) : m_value(value) { }
> + T* value() const { return m_value; }
> + private:
> + T* m_value;
> + };
4 space indent.
More information about the webkit-reviews
mailing list