[webkit-reviews] review granted: [Bug 57644] [GTK] Flash in divs with overflow: auto is not positioned and clipped properly : [Attachment 88273] Patch with Carlos' suggestions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:30:20 PDT 2011


Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 57644: [GTK] Flash in divs with overflow: auto is not positioned and
clipped properly
https://bugs.webkit.org/show_bug.cgi?id=57644

Attachment 88273: Patch with Carlos' suggestions
https://bugs.webkit.org/attachment.cgi?id=88273&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88273&action=review

LGTM. r=me

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:495
> +    // If the width or height are null, set the clipRect to null, indicating
that

s/the width/width/


More information about the webkit-reviews mailing list