[webkit-reviews] review denied: [Bug 55110] fast/forms/input-file-not-open-without-gesture.html passes when a file picker dialog is opened without a gesture. : [Attachment 85900] patch V3

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 55110: fast/forms/input-file-not-open-without-gesture.html passes when a
file picker dialog is opened without a gesture.
https://bugs.webkit.org/show_bug.cgi?id=55110

Attachment 85900: patch V3
https://bugs.webkit.org/attachment.cgi?id=85900&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85900&action=review

Looks like you left out Apple's Windows port. It's also weird to add this new
capability but not any new tests that use it.

> Tools/DumpRenderTree/mac/UIDelegate.mm:267
> +- (void)webView:(WebView *)sender
runOpenPanelForFileButtonWithResultListener:(id<WebOpenPanelResultListener>)res
ultListener allowMultipleFiles:(BOOL)allowMultipleFiles
WEBKIT_OBJC_METHOD_ANNOTATION(AVAILABLE_IN_WEBKIT_VERSION_4_0)

No need for the annotation here.