[webkit-reviews] review denied: [Bug 59235] [Chromium] createWindow() does not pass url to createView() in the case of a FrameLoadRequest : [Attachment 90765] fix

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied anthony taranto
<anthony.taranto at gmail.com>'s request for review:
Bug 59235: [Chromium] createWindow() does not pass url to createView() in the
case of a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=59235

Attachment 90765: fix
https://bugs.webkit.org/attachment.cgi?id=90765&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90765&action=review

> Source/WebKit/chromium/public/WebViewClient.h:90
> +				   const WebURL& url,

what does this "url" refer to, and under what conditions does it differ from
request.url()?

it is very confusing for this method to be passed two "urls"... which one is
meaningful to
the implementer of the createView method?  perhaps we should make sure that
request.url()
is always meaningful?