[webkit-reviews] review denied: [Bug 58447] Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size : [Attachment 89386] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 03:55:07 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 58447: Web Inspector: ResourceResponse should have encodedDataLength field
for synchronous requests transfer size
https://bugs.webkit.org/show_bug.cgi?id=58447

Attachment 89386: Patch
https://bugs.webkit.org/attachment.cgi?id=89386&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review

> Source/WebCore/loader/FrameLoader.cpp:2829
> +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(),
identifier, response, data.size(),
static_cast<int>(response.encodedDataLength()), error);

what are the implications of this change?

> Source/WebCore/platform/network/ResourceResponseBase.h:68
> +    long long encodedDataLength() const;

This should be a part of ResourceLoadInfo.


More information about the webkit-reviews mailing list