[webkit-reviews] review denied: [Bug 58139] Web Inspector: No headers information in network panel for downloads. : [Attachment 89414] Patch with fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 03:55:51 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 58139: Web Inspector: No headers information in network panel for
downloads.
https://bugs.webkit.org/show_bug.cgi?id=58139

Attachment 89414: Patch with fix
https://bugs.webkit.org/attachment.cgi?id=89414&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89414&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:680
> +    InspectorInstrumentation::didReceiveResourceResponseButCanceled(frame,
loader, identifier, r);

Instrumentation header should have no logic and bring all signals to the
implementation as is.


More information about the webkit-reviews mailing list