[webkit-reviews] review denied: [Bug 58259] Web Inspector: Enable raw HTTP headers support : [Attachment 89384] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 03:53:02 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 58259: Web Inspector: Enable raw HTTP headers support
https://bugs.webkit.org/show_bug.cgi?id=58259

Attachment 89384: Patch
https://bugs.webkit.org/attachment.cgi?id=89384&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89384&action=review

Couple of nits, otherwise looks good.

> Source/WebCore/inspector/front-end/ResourceHeadersView.js:226
> +

nit: remove extra space

> Source/WebCore/inspector/front-end/ResourceHeadersView.js:324
> +	   var title = "<span class=\"header-value source-code\">" +
String(rawHeadersText).trim().escapeHTML() + "</span>"

You should fill this is programmatically (once item is appended, you can
reference its listItemElement and fill it in).


More information about the webkit-reviews mailing list