[webkit-reviews] review denied: [Bug 43216] Script engine agnostic ScriptCallback class : [Attachment 67939] patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied  review:
Bug 43216: Script engine agnostic ScriptCallback class
https://bugs.webkit.org/show_bug.cgi?id=43216

Attachment 67939: patch
https://bugs.webkit.org/attachment.cgi?id=67939&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67939&action=review

> WebCore/bindings/js/ScriptFunctionCall.h:68
> +	   JSC::MarkedArgumentBuffer m_arguments;

MarkedArgumentBuffer can't be heap allocated, so in addition to pulling
MarkedArgumentBuffer up to this point you should also pull
// MarkedArgumentBuffer must be stack allocated, so prevent heap
void* operator new(size_t) { ASSERT_NOT_REACHED(); return
reinterpret_cast<void*>(0xbadbeef); }
void* operator new[](size_t) { ASSERT_NOT_REACHED(); return
reinterpret_cast<void*>(0xbadbeef); }

r-, because this could actually result in real bustage being introduced