[webkit-reviews] review denied: [Bug 45271] HTML parser should provide script column position within HTML document to JavaScript engine : [Attachment 68392] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 22 11:25:05 PDT 2010
Adam Barth <abarth at webkit.org> has denied Peter Rybin <peter.rybin at gmail.com>'s
request for review:
Bug 45271: HTML parser should provide script column position within HTML
document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271
Attachment 68392: Patch
https://bugs.webkit.org/attachment.cgi?id=68392&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
You didn't address my comments on the previous patch. You didn't provide
benchmark scores. Why do we need an HTMLPositionProvider? You should just put
the position information on the token since that's the thing that has a
position.
More information about the webkit-reviews
mailing list