[webkit-reviews] review granted: [Bug 46201] Need to stop autocorrection panel timer after editing. : [Attachment 68385] Proposed patch (v1)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 11:23:17 PDT 2010


mitz at webkit.org has granted jpu at apple.com's request for review:
Bug 46201: Need to stop autocorrection panel timer after editing.
https://bugs.webkit.org/show_bug.cgi?id=46201

Attachment 68385: Proposed patch (v1)
https://bugs.webkit.org/attachment.cgi?id=68385&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68385&action=review

> WebCore/editing/Editor.h:315
>      void startCorrectionPanelTimer();
> +    void stopCorrectionPanelTimer();

I don’t think these two methods need to be public. r+ but please upload a new
patch making these methods private if possible. If not, set the “cq” flag to ?
and I will set to + and the patch will be committed as-is.


More information about the webkit-reviews mailing list