[webkit-reviews] review granted: [Bug 45362] Reduce minimum DOMTimer interval : [Attachment 68399] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 45362: Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Attachment 68399: Patch
https://bugs.webkit.org/attachment.cgi?id=68399&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68399&action=review

Seems OK, but the WebKit part of this could use some additional refinement.

> WebKit/mac/WebView/WebView.mm:699
> -    _private->page->settings()->setMinDOMTimerInterval(0.004);
> +    Settings::setMinDOMTimerInterval(0.004);

It doesn’t make sense to call this over and over again, each time we initialize
a WebView. Instead we could call this in a method like +[WebView initialize]
along with all the other one-time initialization that is done there.

> WebKit/win/WebView.cpp:2592
> -    m_page->settings()->setMinDOMTimerInterval(0.004);
> +    Settings::setMinDOMTimerInterval(0.004);

Same comment here. This should be part of one-time initialization, not
per-WebView initialization.