[webkit-reviews] review granted: [Bug 46225] new-run-webkit-tests: add support for chromium gpu port, accelerated switches : [Attachment 68335] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46225: new-run-webkit-tests: add support for chromium gpu port, accelerated
switches
https://bugs.webkit.org/show_bug.cgi?id=46225

Attachment 68335: Patch
https://bugs.webkit.org/attachment.cgi?id=68335&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68335&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:45
> +	   if sys.platform in ('cygwin', 'win32'):
> +	       port_name = 'chromium-gpu-win'
> +	   elif sys.platform == 'linux2':
> +	       port_name = 'chromium-gpu-linux'

python pro-tip: this could be rewritten as:
plaforms = {
  'cygwin': '-win',
  'win32': '-win',
  'linux2': '-linux',
  'darwin': '-mac',
}
if sys.platform not in platforms:
    raise NotImplementedError('...')
port_name += platforms[sys.platform]