[webkit-reviews] review granted: [Bug 46279] Random plug-in cleanups : [Attachment 68395] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46279: Random plug-in cleanups
https://bugs.webkit.org/show_bug.cgi?id=46279

Attachment 68395: Patch
https://bugs.webkit.org/attachment.cgi?id=68395&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68395&action=review

> WebKit2/WebProcess/Plugins/Plugin.cpp:48
> +    parameters.url = KURL(ParsedURLString, urlString);

Are you sure this is the constructor we want to use here? This is normally only
suitable if we know that the URL is already parsed by KURL and the string came
out of KURL. Is that going to be true. Further, is this consistent with the
“don’t trust the other process” philosophy?

> WebKit2/WebProcess/Plugins/Plugin.cpp:57
> +    if (!decoder->decode(parameters.names))
> +	   return false;
> +    if (!decoder->decode(parameters.values))
> +	   return false;
> +    if (!decoder->decode(parameters.mimeType))
> +	   return false;
> +    if (!decoder->decode(parameters.loadManually))
> +	   return false;

Do these functions normally check for validity? For example, are the names and
values arrays the same length? Are they all strings in those arrays? Are there
any invalid values for anything?