[webkit-reviews] review granted: [Bug 43216] Script engine agnostic ScriptCallback class : [Attachment 67939] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 43216: Script engine agnostic ScriptCallback class
https://bugs.webkit.org/show_bug.cgi?id=43216

Attachment 67939: patch
https://bugs.webkit.org/attachment.cgi?id=67939&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67939&action=review

> WebCore/bindings/js/ScriptFunctionCall.cpp:219
> +    ASSERT(callType != CallTypeNone);

What makes this assertion correct? Can we ever get CallTypeNone here? We must
only assert something we know will be true for some reason.

> WebCore/bindings/js/ScriptFunctionCall.h:69
> +    protected:
> +	   JSC::MarkedArgumentBuffer m_arguments;
> +	   ScriptState* m_exec;

Normally we would make data members private, and give derived classes access
with protected accessor functions.