[webkit-reviews] review granted: [Bug 44628] [Skia] canvas/philip/tests/2d.imageData.get.source.outside.html crashes test_shell in Chromium Linux debug : [Attachment 65964] Patch with early return.

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dominic Cooney
<dominicc at google.com>'s request for review:
Bug 44628: [Skia] canvas/philip/tests/2d.imageData.get.source.outside.html
crashes test_shell in Chromium Linux debug
https://bugs.webkit.org/show_bug.cgi?id=44628

Attachment 65964: Patch with early return.
https://bugs.webkit.org/attachment.cgi?id=65964&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +
> +	   Fixes getImageData in the Chromium Skia port so that it doesn't
> +	   retrieve the pointer into the canvas bitmap when there are no
> +	   columns to copy. Retrieving the pointer asserts when the source is
> +	   outside the canvas bounds.
> +

The double negative here is confusing.	Can you please reword this sentence?

Otherwise, looks great.  canvas/philip/ is still marked as SKIP in the chromium
test_expectations so there's not much point in updating it at this point.