[webkit-reviews] review denied: [Bug 45331] [Qt] Calling Path::closeSubpath() when the path only contains only one line or curve element does not result in the path being closed : [Attachment 66782] Proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Jan Erik Hanssen
<jhanssen at gmail.com>'s request for review:
Bug 45331: [Qt] Calling Path::closeSubpath() when the path only contains only
one line or curve element does not result in the path being closed
https://bugs.webkit.org/show_bug.cgi?id=45331

Attachment 66782: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=66782&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +#if PLATFORM(QT)
> +	   m_path.closeCanvasSubpath();
> +#else
>	   m_path.closeSubpath();
> +#endif

It's rather un-obvious why we're doing something differently on Qt here.

I think all platforms should have closeCanvasSubpath() and we'd call that from
here instead.

For non-Qt ports, it could be an inline call to closeSubpath() in Path.h