[webkit-reviews] review granted: [Bug 45334] TextDocument should come in from the cold : [Attachment 66786] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 45334: TextDocument should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=45334

Attachment 66786: Patch
https://bugs.webkit.org/attachment.cgi?id=66786&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66786&action=prettypatch

> WebCore/html/parser/HTMLViewSourceParser.cpp:47
> +    m_tokenizer->setState(HTMLTokenizer::PLAINTEXTState);
We talked about just making HTMLViewTextSourceParser a subclass which does this
in the constructor.

> WebCore/html/parser/TextDocumentParser.cpp:52
> +    attributes->insertAttribute(styleAttribute.release(), false);
What does false do?

> WebCore/html/parser/TextDocumentParser.cpp:78
> +    pumpTokenizer();
m_treeBuilder->finished() is needed.  Lame that every document parser needs to
write all this stuff.