[webkit-reviews] review denied: [Bug 48342] Fix and cleanup of build systems : [Attachment 71907] proposed fix

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 48342: Fix and cleanup of build systems
https://bugs.webkit.org/show_bug.cgi?id=48342

Attachment 71907: proposed fix
https://bugs.webkit.org/attachment.cgi?id=71907&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review

r- to fix the FeatureDefines.xcconfig files.  (Note that I only reviewed
build-webkit and the Apple Xcode config files.)

> WebKit/mac/Configurations/FeatureDefines.xcconfig:-99
> -

Note that JavaScriptCore/Configurations/FeatureDefines.xcconfig should be
exactly the same as WebCore/Configurations/FeatureDefines.xcconfig,
WebKit/mac/Configurations/Configurations/FeatureDefines.xcconfig and
WebKit2/Configurations/FeatureDefines.xcconfig.

It appears that ENABLE_FULLSCREEN_API is missing from all but JavaScriptCore's
configuration file, and that WebKit2/Configurations/FeatureDefines.xcconfig is
missing ENABLE_ACCELERATED_2D_CANVAS.

Thus I would copy JavaScriptCore/Configurations/FeatureDefines.xcconfig to
replace all the other FeatureDefines.xcconfig files.

> WebKitTools/Scripts/build-webkit:-201
> -

The build-webkit script also appears to be missing ENABLE_FULLSCREEN_API
support as well.