[webkit-reviews] review granted: [Bug 46540] Resuming animations causes webkitAnimationStart events to be fired : [Attachment 71920] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 46540: Resuming animations causes webkitAnimationStart events to be fired
https://bugs.webkit.org/show_bug.cgi?id=46540

Attachment 71920: Patch
https://bugs.webkit.org/attachment.cgi?id=71920&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71920&action=review

r=me with some test tweaking.

> WebCore/page/animation/KeyframeAnimation.h:93
> +    bool m_startEventSent;

Maybe call this m_startEventDispatched?

> LayoutTests/animations/suspend-resume-animation-events.html:15
> +	 -webkit-animation-duration: 1s;
> +	 -webkit-animation-timing-function: linear;
> +	 -webkit-animation-direction: alternate;
> +	 -webkit-animation-iteration-count: 2;

It's a shame to add another animation test that takes significant time (slowing
down the bots and everyone running tests). We should strive to make the test as
brief as possible.

> LayoutTests/animations/suspend-resume-animation-events.html:64
> +    runAnimationTest(expectedValues, setTimers, undefined, true);

Please add inline comments (or use named variables) to explain what 'undefined'
and 'true' mean.

> LayoutTests/animations/suspend-resume-animation-events.html:72
> +This test shows suspend and resume of a box moving to the right 500px and
then back to 0px. If running inside 
> +DumpRenderTest the box should stop at 200px after 400ms. After another 600ms
the move should resume and then 
> +continue to complete the move in another 1.6s.

This text is superfluous.