[webkit-reviews] review denied: [Bug 38956] [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails : [Attachment 71921] Fix basic authentication in WebKitGtk+

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 38956: [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
https://bugs.webkit.org/show_bug.cgi?id=38956

Attachment 71921: Fix basic authentication in WebKitGtk+
https://bugs.webkit.org/attachment.cgi?id=71921&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71921&action=review

This looks great! There are just a couple small issues.

> WebCore/ChangeLog:11
> +	   Added a new utility function that turns SoupURI's into
> +	   KURL's. That addresses some issues with SoupURI's like for example
> +	   soup_uri_to_string ignoring the URI password. Basic authentication
> +	   using URL credentials should work now.

I think all the SoupURI's and KURL's should be SoupURIs and KURLs.

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:759
> +    ResourceHandleInternal* d = handle->getInternal();
> +
> +    d->m_context = context;
>      handle->start(context);

How does this relate to the rest of the patch? It's very unclear to me. Perhaps
a note in the ChangeLog at line 16.

> WebCore/platform/network/soup/SoupURIUtils.h:27
> +#ifndef UriSoup_h
> +#define UriSoup_h

You should update the header guard.