[webkit-reviews] review granted: [Bug 46743] Event dispatching in XMLHttpRequestProgressEventThrottle should go through XMLHttpRequestProgressEventThrottle::dispatchEvent : [Attachment 69088] [PATCH] Refactor XMLHttpRequestProgressEventThrottle event dispatching (with ChangeLog)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 17:09:16 PDT 2010


Darin Adler <darin at apple.com> has granted Anton D'Auria <adauria at apple.com>'s
request for review:
Bug 46743: Event dispatching in XMLHttpRequestProgressEventThrottle should go
through XMLHttpRequestProgressEventThrottle::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=46743

Attachment 69088: [PATCH] Refactor XMLHttpRequestProgressEventThrottle event
dispatching (with ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=69088&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I do not like the ProgressEventAction design here. It seems if we want to do
two things we should call two functions, or we can have a function that does
two things, but having function with a passed parameter that tells it to either
do two things or one thing seems unnecessarily confusing.


More information about the webkit-reviews mailing list