[webkit-reviews] review denied: [Bug 45716] [BREWMP] Port unicode : [Attachment 67490] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 45716: [BREWMP] Port unicode
https://bugs.webkit.org/show_bug.cgi?id=45716

Attachment 67490: Patch
https://bugs.webkit.org/attachment.cgi?id=67490&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=67490&action=review

r- because of style errors.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:84
> +    int remainingCharacters = 0;

remainingCharacters should be declared just before it is used.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:85
> +    if (sourceLength <= resultLength)

You should enclose this block with {} because the block contains two physical
lines.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:88
> +    else

ditto.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:101
> +int toUpper(UChar* result, int resultLength, const UChar* source, int
sourceLength, bool* isError)

Same comments as toLower().