[webkit-reviews] review requested: [Bug 47632] Only draw focus ring in RenderInline and RenderImage if the theme is not able to draw a focus ring : [Attachment 70686] Patch with pixel-tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 47632: Only draw focus ring in RenderInline and RenderImage if the theme is
not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632

Attachment 70686: Patch with pixel-tests
https://bugs.webkit.org/attachment.cgi?id=70686&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Added Mac pixel tests to ensure that we don't regress focus ring drawing on the
Mac port. Will follow up to generate pixel test results for Windows (if they
differ) as well as other ports.

While working on this patch, I noticed that on Mac Safari the default focus
ring color for <area> (when the CSS outline-color property is unspecified) is
black which differs from the default Aqua-blue focus ring color for both
hyperlinks and form controls. This seems weird. We should look into this
further to ensure this is expected and I think this is best addressed in a
separate bug.