[webkit-reviews] review granted: [Bug 50197] config.webkit_base_dir returns a path with a trailing slash : [Attachment 75094] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 30 09:21:25 PST 2010
Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 50197: config.webkit_base_dir returns a path with a trailing slash
https://bugs.webkit.org/show_bug.cgi?id=50197
Attachment 75094: Patch
https://bugs.webkit.org/attachment.cgi?id=75094&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75094&action=review
> WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:135
> + self._webkit_base_dir = abspath[0:abspath.find('WebKitTools') -
1]
Seems like I could construct cases where this would break, but this seems good
enough and concise.
More information about the webkit-reviews
mailing list