[webkit-reviews] review denied: [Bug 49914] GraphicsContext: Merge m_common and m_data : [Attachment 75155] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 49914: GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914

Attachment 75155: Patch
https://bugs.webkit.org/attachment.cgi?id=75155&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75155&action=review

> WebCore/platform/graphics/GraphicsContext.h:445
>	   static GraphicsContextPrivate* createGraphicsContextPrivate();
>	   static void destroyGraphicsContextPrivate(GraphicsContextPrivate*);

These two methods should be removed since they are no longer used/needed.

> WebCore/platform/graphics/wx/GraphicsContextWx.cpp:139
>      destroyGraphicsContextPrivate(m_common);
> -    delete m_data;
> +    delete platformPrivate();

This will crash! (Double delete)