[webkit-reviews] review granted: [Bug 50213] All projects on Windows should use cmd files for build events : [Attachment 75112] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 50213: All projects on Windows should use cmd files for build events
https://bugs.webkit.org/show_bug.cgi?id=50213

Attachment 75112: Patch
https://bugs.webkit.org/attachment.cgi?id=75112&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75112&action=review

Maybe we should move the which.exe/buildfailed stuff into common.vsprops?

> WebKit2/win/WebKitPreBuild.cmd:11
> +cl /analyze /nologo /c "%WEBKITOUTPUTDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj"
2>&1 | findstr D9040
> +if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false")
> +if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set
AnalyzeWithLargeStack="")

Does anyone use PREfast anymore?