[webkit-reviews] review granted: [Bug 49672] Allow no-store resources to be used for back navigation : [Attachment 74193] [PATCH] Do No Mark "https" Resources as Allowed For History

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 49672: Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672

Attachment 74193: [PATCH] Do No Mark "https" Resources as Allowed For History
https://bugs.webkit.org/attachment.cgi?id=74193&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74193&action=review

r=me, but please fix that function to remove the unnecessary conversion to
KURL, and try to find out why the Windows EWS build is failing.

> WebCore/loader/cache/CachedResource.cpp:259
> +	       if (KURL(ParsedURLString, url()).protocolIs("https"))

There is no need to parse a URL just to check its protocol. The KURL.h header
has a protocolIs function that takes a string for this reason.